Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_calibrate_tas: allow selecting predictors #291

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

mathause
Copy link
Member

This adds the use_tas2 and use_hfds keywords to _calibrate_tas which allows to set whether tas ** 2 and hfds are used for calibration. This would add some tests, however, these are slow ones and it adds some seconds to the test suite (see also #290). So I need to consider if I want to merge this...

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (70a6a0e) 86.99% compared to head (a2b4ed1) 86.89%.
Report is 1 commits behind head on main.

❗ Current head a2b4ed1 differs from pull request most recent head c197bf9. Consider uploading reports for the commit c197bf9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   86.99%   86.89%   -0.10%     
==========================================
  Files          38       38              
  Lines        1599     1580      -19     
==========================================
- Hits         1391     1373      -18     
+ Misses        208      207       -1     
Flag Coverage Δ
unittests 86.89% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mesmer/calibrate_mesmer/calibrate_mesmer.py 92.56% <100.00%> (+1.38%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit d2e036a into MESMER-group:main Sep 27, 2023
4 checks passed
@mathause mathause deleted the _calibrate_tas_select_preds branch September 27, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant