Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to cc65 build as well as fileio test #39

Merged
merged 22 commits into from
Jul 31, 2023
Merged

Conversation

mlund
Copy link
Collaborator

@mlund mlund commented Jul 25, 2023

Changes

  • Fixed broken fileio.s assembly code for llvm-mos (see Tests for fileio and dirent #34) by changing calling convention.
  • Fixed broken getrtc() function when running on Xemu.
  • Add doxygen comments to selected functions
  • Some type refactoring towards stdlib types.
  • Add TARGET_EMULATION for detecting Xemu.
  • New make test target for the cc65 Makefile
  • New tests: test-fileio and test-time. Running looks something like this and passes on both cc65 and clang:
Running tests...
Test project /Users/mikael/github/mega65-libc/build
    Start 1: test-fileio
1/4 Test #1: test-fileio ......................   Passed    0.85 sec
    Start 2: test-integer-size
2/4 Test #2: test-integer-size ................   Passed    0.84 sec
    Start 3: test-memory
3/4 Test #3: test-memory ......................   Passed    0.84 sec
    Start 4: test-time
4/4 Test #4: test-time ........................   Passed    0.84 sec

100% tests passed, 0 tests failed out of 4

CC65 vs. Clang file size

Clang generated output is significantly smaller:

File CC65 Clang
test-fileio.prg 3706 743
test-integer-size.prg 3152 135
test-memory.prg 3782 1203
test-time.prg 4822 1036

And apologies for this rather large PR; it should have been split into smaller pieces.

@mlund mlund added the enhancement New feature or request label Jul 25, 2023
@mlund mlund self-assigned this Jul 25, 2023
@mlund mlund requested a review from lydon42 July 25, 2023 19:35
@mlund mlund marked this pull request as ready for review July 25, 2023 19:48
mlund added 2 commits July 26, 2023 10:34
This requires Xemu 20230726102337/next or later (June 26, 2023)
@mlund mlund requested a review from dansanderson July 28, 2023 04:54
@mlund mlund mentioned this pull request Jul 28, 2023
3 tasks
Copy link
Member

@lydon42 lydon42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate on the all target order or change it back to be the top target.

Makefile_cc65 Outdated Show resolved Hide resolved
@mlund mlund merged commit 0f7bdab into master Jul 31, 2023
@mlund mlund deleted the reduce-warnings branch July 31, 2023 06:36
@mlund mlund mentioned this pull request Jul 31, 2023
6 tasks
@mlund mlund mentioned this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants