Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inverse search and fixed deprecated diagnostic setting #80

Open
wants to merge 1 commit into
base: latex-ide
Choose a base branch
from
Open

Added inverse search and fixed deprecated diagnostic setting #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
lvim.format_on_save = false
lvim.lsp.diagnostics.virtual_text = true

vim.diagnostic.config({virtual_text = true})
lvim.builtin.treesitter.highlight.enable = true

-- Auto install treesitter parsers.
Expand Down Expand Up @@ -39,6 +38,8 @@ vim.cmd([[

-- Vimtex configuration.
vim.g.vimtex_view_method = "zathura"
-- Enable inverse search (set progpath to location of lvim executable)
vim.g.vimtex_callback_progpath = vim.fn.expand('$HOME/.local/bin/lvim')
vim.g.vimtex_quickfix_enabled = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, why is this disabled by default for LunarVim? I would claim that the quickfix feature is very useful and quite well implemented in VimTeX. Is it because you are also loading texlab or something like that which gives the same functionality?

Copy link
Author

@estrac estrac Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great question for @SingularisArt, who was the original author of the LaTeX config.lua for LunarVim. Both texlab and VimTeX are being loaded in the config file, so I would presume you're right -- LunarVim probably wants to support both packages.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool; I believe you still want to load the quickfix module even if you do use texlab. But you may want to disable the auto open feature. I.e., I would propose the following change:

-vim.g.vimtex_quickfix_enabled = 0
+vim.g.vimtex_quickfix_mode = 0


-- Setup cmp.
Expand Down