Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using SQLite as a DB #271

Merged
merged 11 commits into from
Oct 1, 2023

Conversation

lyricnz
Copy link
Contributor

@lyricnz lyricnz commented Sep 25, 2023

Related to #268

  • removes need for docker for local development/execution (once you have the DB file)
  • removes need for 3GB docker image
  • removes need for cpu + memory required to run postgres in docker

Future work:

  • publish the DB image somewhere; Perhaps using Git LFS
  • compress?
  • read-only?
  • automatic bootstrap if DB file not found (download, unpack etc)
  • web-based DB file, using range HTTP requests?

@lyricnz lyricnz marked this pull request as ready for review September 25, 2023 23:18
@lyricnz
Copy link
Contributor Author

lyricnz commented Sep 25, 2023

PR also removes db.get_list_vs_total() which wasn't used anyway

@lyricnz
Copy link
Contributor Author

lyricnz commented Sep 27, 2023

Sample releases (from my fork): https://github.com/lyricnz/nbn-upgrade-map/releases

@lyricnz
Copy link
Contributor Author

lyricnz commented Sep 28, 2023

So @LukePrior ?

@LukePrior LukePrior merged commit d16cb18 into LukePrior:main Oct 1, 2023
6 checks passed
@LukePrior
Copy link
Owner

Looks good

@lyricnz lyricnz deleted the feature/sqlite branch October 1, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants