Don't pin fake and quickcheck to older versions

LukeMathWalker · Aug 29, 2024 · 8dec61a · 8dec61a
1 parent 9130cc3
commit 8dec61a
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 91 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -46,9 +46,9 @@ tracing-actix-web = "0.7"
 secrecy = { version = "0.8", features = ["serde"] }
 
 [dev-dependencies]
-quickcheck = "0.9.2"
-quickcheck_macros = "0.9.1"
-fake = "~2.3.0"
+quickcheck = "1.0.3"
+quickcheck_macros = "1"
+fake = "2.9"
 wiremock = "0.6"
 serde_json = "1.0.61"
 linkify = "0.10"

diff --git a/src/domain/subscriber_email.rs b/src/domain/subscriber_email.rs
@@ -31,6 +31,8 @@ mod tests {
     use claims::assert_err;
     use fake::faker::internet::en::SafeEmail;
     use fake::Fake;
+    use rand::rngs::StdRng;
+    use rand::SeedableRng;
 
     #[test]
     fn empty_string_is_rejected() {
@@ -54,8 +56,10 @@ mod tests {
     struct ValidEmailFixture(pub String);
 
     impl quickcheck::Arbitrary for ValidEmailFixture {
-        fn arbitrary<G: quickcheck::Gen>(g: &mut G) -> Self {
-            let email = SafeEmail().fake_with_rng(g);
+        fn arbitrary(g: &mut quickcheck::Gen) -> Self {
+            let mut rng = StdRng::seed_from_u64(u64::arbitrary(g));
+            let email = SafeEmail().fake_with_rng(&mut rng);
+
             Self(email)
         }
     }