Don't assume that all notifications are NotifySlotChange #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
force-pushed
the
check-notification-type
branch
from
3dd4ffc to
1394d11
Compare
LudovicRousseau
requested changes
Dec 12, 2024
|
I like your changes. It is good work. |
bluetech
force-pushed
the
check-notification-type
branch
from
1394d11 to
982b68f
Compare
|
Thanks for the review, I addressed your comments. |
This is somewhat nice for readability, but will be useful for the next commit.
CCID defines another type of message type on the interrupt pipe, HardwareError, and others may also be conceivably sent. So check the message type instead of assuming it's a NotifySlotChange. While at it, I added debug logging of HardwareError, it might be useful for someone.
bluetech
force-pushed
the
check-notification-type
branch
from
982b68f to
7adefa1
Compare
|
I added the |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCID defines another type of message type on the interrupt pipe,
HardwareError, and others may also be conceivably sent. So check the
message type instead of assuming it's a NotifySlotChange.
While at it, I added debug logging of HardwareError, it might be useful
for someone.
Note 1: I recommend viewing the second commit ignoring whitespace, it makes the diff clearer.
Note 2: I don't have a multi-slot reader, so I wasn't able to test the
Multi_code paths.