Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] partner_address_street3: Migration to 18.0 #1

Closed
wants to merge 11 commits into from
Closed

[18.0][MIG] partner_address_street3: Migration to 18.0 #1

wants to merge 11 commits into from

Conversation

LucasTran380381
Copy link
Owner

@LucasTran380381 LucasTran380381 commented Oct 22, 2024 •
edited
Loading

Ref: [partner_address_street3](https://github.com/OCA/partner-contact/issues/1856)

@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-partner_address_street3 branch 2 times, most recently from 715a38c to 1f73b8e Compare October 22, 2024 10:50
@LucasTran380381 LucasTran380381 changed the title migration to v18 [18.0][MIG] partner_address_street3: Migration to 18.0 Oct 23, 2024
@nilshamerlinck
Copy link

nilshamerlinck commented Oct 23, 2024 •
edited
Loading

ok, commit name should be [MIG] partner_address_street3: Migration to 18.0 too
anything noteworthy to add in the PR description to help reviewer's life? (e.g. about the view changes)

@nilshamerlinck
Copy link

you can add yourself to CONTRIBUTORS.md and then announce your PR in #trobz-oca-migrations to get a review from a peer

@nilshamerlinck
Copy link

in terms of commits, I think you squashed a bit too much: you should keep pre-commit auto fixes commits separated from migration commits

@LucasTran380381 LucasTran380381 deleted the 18.0-mig-partner_address_street3 branch October 23, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilshamerlinck nilshamerlinck nilshamerlinck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LucasTran380381 @nilshamerlinck @nbessi @gurneyalex @HviorForgeFlow @alexis-via @emagdalenaC2i @SodexisTeam