Support English double quotation marks for escaping (#172)

* Support English double quotation marks
LucaBernstein · Jul 27, 2022 · 6c9bc78 · 6c9bc78
1 parent fc9b398
commit 6c9bc78
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/helpers/subcommands.go b/helpers/subcommands.go
@@ -94,7 +94,7 @@ func SplitQuotedCommand(s string) (res []string) {
 			isEscaped = true
 			continue
 		}
-		if c == '"' {
+		if c == '"' || c == '“' {
 			isQuoted = !isQuoted
 			continue
 		}

diff --git a/helpers/subcommands_test.go b/helpers/subcommands_test.go
@@ -60,6 +60,8 @@ func TestSplitQuotedCommand(t *testing.T) {
 	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command "is quoted" non-quoted and sep`), []string{"/command", "is quoted", "non-quoted", "and", "sep"}, "")
 	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command hello"world"`), []string{"/command", "helloworld"}, "")
 	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command hello "world"`), []string{"/command", "hello", "world"}, "")
+	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command special “quotations“`), []string{"/command", "special", "quotations"}, "")
+	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command special “quotations 2"`), []string{"/command", "special", "quotations 2"}, "")
 	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command hello" world"`), []string{"/command", "hello world"}, "")
 	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command "wrongly quoted`), []string{}, "quotes opened but not closed")
 	helpers.TestExpectArrEq(t, helpers.SplitQuotedCommand(`/command \"correctly quoted`), []string{"/command", "\"correctly", "quoted"}, "quotes opened but not closed")