Skip to content

Commit

Permalink
test/system: remove system dial-stdio test
Browse files Browse the repository at this point in the history
This test a pretty much useless, it checks that a connection attempt on
the default socket fails. But this is incorrect as the socket is outside
of the test control as such it might be ready to accept connections as
thus the test can fail locally or as reported here in the debian tests.

Given that a simple connection fails does not add any value I opted to
remove it.

Fixes containers#24803

Signed-off-by: Paul Holzinger <[email protected]>
  • Loading branch information
Luap99 committed Dec 17, 2024
1 parent 153a975 commit 8729725
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions test/e2e/system_dial_stdio_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ var _ = Describe("podman system dial-stdio", func() {
Expect(session.OutputToString()).To(ContainSubstring("Examples: podman system dial-stdio"))
})

It("podman system dial-stdio while service is not running", func() {
if IsRemote() {
Skip("this test is only for non-remote")
}
session := podmanTest.Podman([]string{"system", "dial-stdio"})
session.WaitWithDefaultTimeout()
Expect(session).Should(ExitWithError(125, "Error: failed to open connection to podman"))
})
// TODO: this should have a proper connection test where we spawn a server
// and the use dial-stdio to connect to it and send data.
})

0 comments on commit 8729725

Please sign in to comment.