Fix: default to undefined generator for parsed lotties #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f450904 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
➿ Code coverage
|
jawish
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
The library currently sets itself as the default generator, even when it is passed a Lottie that does not have a generator. Override behavior of
Animation.fromJSONto set metadata fields as undefined when a Lottie without metadata is passed.The keywords is also changed to be an empty array, instead of array of length 1 in this case.
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Animation.meta.generatoris set to@lottiefiles/lottie-js ${version}when initialized from a JSON object without metadataAnimation.meta.keywordsis set to an array of length one, with anundefinedelement, when initialized from a JSON object without metadataIssue Number: N/A
What is the new behavior?
Animation.meta.generatorwill be undefined when initialized from a JSON object without metadata.Animation.meta.keywordswill be an empty array when initialized from a JSON object without metadata.Does this introduce a breaking change?
Other information