Skip to content

Commit

Permalink
Merge pull request #749 from marionbarker/working-docs
Browse files Browse the repository at this point in the history
Fix a few typos and link errors
  • Loading branch information
marionbarker authored Oct 26, 2023
2 parents c37e97b + cf4032b commit 2d2d15e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 7 additions & 7 deletions docs/gh-actions/gh-errors.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,17 +176,17 @@ Follow these steps:
!!! tip "Open each link below in a separate tab"
It is best to open each link below in a separate tab so you can return to this list and keep using the links in each step.
1. Delete all the identifiers that you can, following the steps in [First Time: Delete Identifiers](gh-first-time.md#delete-identifiers)
1. Delete all the identifiers that you can, following the steps in [Configure to Use Browser: Delete Identifiers](gh-first-time.md#delete-identifiers)
- Delete all the other identifiers first, then try to delete the *Loop* identifier with the wrong <code>TEAMID</code>
- It is fine to just ignore identifiers with the wrong <code>TEAMID</code>, but do not use them
1. Enter your `TEAMID` correctly in the repository `Secrets`
- Make sure you use copy and paste from your [Apple Developer Membership](https://developer.apple.com/account/#!/membership) page for that `TEAMID`.
- Follow the update instructions here (this example is for `GH_PAT`, you'll do the same but for `TEAMID`) [Update Secrets](gh-update.md#update-secrets)
1. Run Action: [First Time: `Add Identifiers`](gh-first-time.md#add-identifiers) again
1. Run Action: [Configure to Use Browser: `Add Identifiers`](gh-first-time.md#add-identifiers) again
1. Follow all the steps in this section with the **correct** `TEAMID` [First Time: Configure Identifiers for Loop](gh-first-time.md#configure-identifiers-for-loop) but when you get to the [First Time: Create Loop App in App Store Connect](gh-first-time.md#create-loop-app-in-app-store-connect), you need to return to this page and follow the instructions below to remove the app and add a new one.
1. Follow all the steps in this section with the **correct** `TEAMID` [Configure to Use Browser: Configure Identifiers for Loop](gh-first-time.md#configure-identifiers-for-loop) but when you get to the [Configure to Use Browser: Create Loop App in App Store Connect](gh-first-time.md#create-loop-app-in-app-store-connect), you need to return to this page and follow the instructions below to remove the app and add a new one.
The first time through, you created an app with a `Bundle ID` that does NOT include your `TEAMID`.
Expand Down Expand Up @@ -214,15 +214,15 @@ That *App* with the wrong `Bundle ID` remains in the *App store* but it is hidde
Now click on the `Add Apps` button or the :heavy_plus_sign: (plus sign) if you have other apps in the *App Store*.
Follow the [First Time: Create Loop App in App Store Connect](gh-first-time.md#create-loop-app-in-app-store-connect) directions with these additions:
Follow the [Configure to Use Browser: Create Loop App in App Store Connect](gh-first-time.md#create-loop-app-in-app-store-connect) directions with these additions:
* You must come up with a new name for your *Loop* App
* Triple-check that the `Bundle ID` you choose is for *Loop* and contains your `TEAMID`, it should look like: `com.TEAMID.loopkit.Loop`
* You must come up with a new `SKU` for your *Loop* App (try `1234`, if you used `123` before)
#### Create Certificates
You should be able to continue with the First Time Steps to `Create Certificates` and then `Build Loop` and keep going.
You should be able to continue with the [Configure to Use Browser Steps to `Create Certificates`](gh-first-time.md#create-certificates) and then proceed from there with `Build Loop` and keep going.
### Error: Missing Repository Access
Expand All @@ -245,7 +245,7 @@ If you see this phrase, the `fastlane` package that is utilized during the `3. C
To fix this error:
- Open this link: [https://github.com/settings/tokens/](https://github.com/settings/tokens/)
- Here you will see your personal access token (`Fastlane Access Token`) that was created during [First Time: Setup *GitHub*: Create `GitHub Personal Access Token`](../gh-actions/gh-first-time.md#create-github-personal-access-token)
- Here you will see your personal access token (`Fastlane Access Token`) that was created during [Configure to Use Browser: Setup *GitHub*: Create `GitHub Personal Access Token`](../gh-actions/gh-first-time.md#create-github-personal-access-token)
- Note that `Tokens (classic)` is highlighted in the menu on the left
- Click on the token name (should be bold, blue **`Fastlane Access Token`** ) to open its detail page
- None of the checkboxes under **`Select Scopes`** will be checked – this is what's causing the issue.
Expand All @@ -260,7 +260,7 @@ NOTE: for next release or if using the dev branch - you want <code>GH_PAT</code>
#### Create Certificates
You should be able to continue with the [First Time Steps to `Create Certificates`](gh-first-time.md#create-certificates) and then proceed from there with `Build Loop` and keep going.
You should be able to continue with the [Configure to Use Browser Steps to `Create Certificates`](gh-first-time.md#create-certificates) and then proceed from there with `Build Loop` and keep going.
### Error: Could not create
Expand Down
14 changes: 7 additions & 7 deletions docs/gh-actions/gh-update.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

**This page is only relevant when building with a browser.**

**For *Mac-Xcode* updates, please see: [Build with *Mac-Xcode*](../build/updating.md)**
**For *Mac-Xcode* updates, please see: [Updating/Rebuilding](../build/updating.md)**

???+ info "Time Estimate (click to open/close)"
Build the *Loop* App
Expand Down Expand Up @@ -113,11 +113,11 @@ Refer to graphic below as you follow the steps to build the *Loop* app.

#### What if the Build Fails

If a new release is announced at [Current Release](../version/releases.md#current-release), look to see if there are instructions about extra steps required with the release. (The release after 3.2.2 will certainly have extra instructions.)
If a new release is announced at [Current Release](../version/releases.md#current-release), look to see if there are instructions about extra steps required with the release. (The release after 3.2.3 will certainly have extra instructions.)

If you are using the dev branch, head over to [Build Development Version](#build-development-version) for information.

Otherwise, head over to [GitHub Errors](gh-errors.md).
Otherwise, head over to [Errors with Browser](gh-errors.md).

#### *Apple* Email to Ignore

Expand All @@ -129,7 +129,7 @@ You'll receive an App Store Connect email confirming that the build has complete

* If you get an email that the action failed, then return to your repository and look for Build Action error messages
* Click on the most recent Build job with the red x by it
* If the details show this message, "[Could not install WWDR certificate](gh-errors.md#could-not-install-wwdr-certificate)"
* If the details show this message, [`Could not install WWDR certificate`](gh-errors.md#could-not-install-wwdr-certificate)
* This means *Apple* did not reply to *GitHub* as fast as *GitHub* expected
* Make sure your developer account is in good standing and that there are no agreements that need to be accepted
* Repeat the build (previous step)
Expand All @@ -154,7 +154,7 @@ Option 1: If you chose to [Disable Automatic Install from *TestFlight*](../gh-ac

* **This is the recommended option**
* Open *TestFlight* on your phone and click `Install` as shown in the GIF below
* If you are building for a child, follow the [Install *TestFlight* Loop for Child](gh-deploy.md#testflightfor-child) instructions again
* If you are building for a child, follow the [*TestFlight* for a Child](gh-deploy.md#testflight-for-a-child) instructions again

![install Loop from *TestFlight*](img/testflight-install-loop.gif){width="300"}
{align="center"}
Expand Down Expand Up @@ -375,7 +375,7 @@ The `bundle ID` for the "`widget`" changed from "`SmallStatusWidget`" to the mor
* Wait for it to succeed
* Add the `App Group` to this one new Identifier

All other identifiers should be already set up. If they are not, please go through the steps on the [GitHub First Time](gh-first-time.md) page to figure out what you are missing.
All other identifiers should be already set up. If they are not, please go through the steps on the [Configure to Use Browser](gh-first-time.md) page to figure out what you are missing.

| `NAME` | `IDENTIFIER` |
|-------|------------|
Expand Down Expand Up @@ -524,7 +524,7 @@ What if I decide I don't want the automatic building feature?
* [GitHub Directions to Disable and Enable a Workflow](https://docs.github.com/en/actions/using-workflows/disabling-and-enabling-a-workflow#disabling-a-workflow)
* It is the Build action that kicks off the update and build steps, so simply disabling the one action is sufficient

* If you are done with Loop, you can delete the whole repository; but you should be sure about this because you'll need to start over with [GitHub First Time](gh-first-time.md) to restore ability to build Loop with GitHub.
* If you are done with Loop, you can delete the whole repository; but you should be sure about this because you'll need to start over with [Configure to Use Browser](gh-first-time.md) to restore ability to build Loop with GitHub.

## Historical Interest Only

Expand Down

0 comments on commit 2d2d15e

Please sign in to comment.