Convert script to Swift Package Manager library #5
Conversation
Logicer16
force-pushed
the
main
branch
2 times, most recently
from
75f0536 to
f65e791
Compare
There was a problem hiding this comment.
Thanks for the pr. Sorry it's taken a bit for me to get around to responding.
I love the premise of Nix and am thankful you've taken the time to help get this working.
The Swift Package Manager aspects look great. Just have some concerns around the SDK version compatibility. If anything is needed in order to get it working with Nix, please let me know.
I'll investigate why CI is failing...
This also avoids the incredibly cursed SDK parsing
The check for the Swift 6.0 compiler was trying to do the same thing (ensure that the 15.0 SDK or newer was in use before compiling code that would error on earlier SDKs), but there were niche situations where it would not work. Thanks to <https://marcoeidinger.github.io/appleframeworks/>, I have found a framework (CoreHID) that only exists in the 15.0 SDK or newer, so I have switched to checking if that module can be imported.
|
I believe I've addressed both your concerns (and I also rebased) |
|
Done. I restored |
|
Perfect! Thanks again for the pr! |
This PR converts the standalone script to a Swift Package Manager library. This is primarily so that I can add this module to Nixpkgs, because the tooling is better for SPM packages than standalone scripts. This change also allowed me to remove the manual parsing of the SDK, which both makes the build similar and also makes it easier to package