Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetDoubleArray () #21

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

GetDoubleArray () #21

wants to merge 2 commits into from

Conversation

shinriyo
Copy link

I hope GetDoubleArray ()
And later. I create int[] version too

we hope just get double[].
later I will add int[] too
It is useful
@lbv lbv mentioned this pull request Aug 17, 2014
@lbv
Copy link
Collaborator

lbv commented Aug 17, 2014

I like the idea, although I think it needs a little more work. For example, if we are going to implement Get methods for arrays of primitive types, it makes sense to provide them for all (GetIntArray, GetStringArray, ...).

Also, a couple of things I'd like to see along with the code changes to the library:

  • Unit tests. For example, what happens if the JSON string is something like [ 1, 2, "c", "d", 5 ]?
  • Examples of how this would be used, to add to the documentation.

But as I said, I like the main idea behind this, so I'll probably help you implement this when I find a little time. Thanks.

@devlead devlead changed the base branch from master to develop December 23, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants