Initial modification sync #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricott1
reviewed
Jun 21, 2024
| { | ||
| emit ETHBridgeFinalized(_from, _to, _amount, _extraData); | ||
| return | ||
| ((_mintableToken == l1USDC && _otherToken == l2USDC) || (_mintableToken == l2USDC && _otherToken == l1USDC)); |
There was a problem hiding this comment.
Can both case actually happen? I would have thought only _mintableToken == l2USDC && _otherToken == l1USDC can be true, but let's check in practice
matjazv
force-pushed
the
temp-check
branch
2 times, most recently
from
e9d09c0 to
a0ccf35
Compare
matjazv
reviewed
Jun 21, 2024
| @@ -166,7 +138,6 @@ contract L1StandardBridge is StandardBridge, ISemver { | |||
| ) | |||
| external | |||
| virtual | |||
| onlyEOA | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP