-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detox failure on jenkins #2078
base: release/3.0.1
Are you sure you want to change the base?
Fix detox failure on jenkins #2078
Conversation
Jenkinsfile
Outdated
# Install Command Line Tools | ||
cp env.test.json env.json | ||
npx react-native start & | ||
xcrun simctl shutdown F084BDF1-55E5-4E4C-B4D6-70AA1DA5D41F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abhishekjalan87, it seems we still have an error here, we might need to run this command without necessarily throwing the error if the device is already shut down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed this issue, now it will not throw any more error if simulator is already in shutdown state.
@@ -0,0 +1,33 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might not need this file either, I created this cause I updated my system to latest and has iPhone 15, but @ClementeSerrano and most likely Jenkins might not have this device. So, this script is to ensure it picks the first device from the system to use. Let me know your thoughts pls.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
…into 1999-fix-detox-failure-on-jenkins-fix
…into 1999-fix-detox-failure-on-jenkins-fix
What was the problem?
Jekins unnable to open Simulator, resolves #1999
How was it solved?
added one line to boot the simulator "xcrun simctl boot"
How was it tested?
Tested locally on a Jenkins node and also using Jenkins pipeline.