[#245] refactor: 토스트 제목 수정 validation 수정 및 그룹설정 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
먼저, 전에 있었던 패턴 코드에서 사용하지 않는 정규식 패턴을 default값으로 가지고 있었어서 수정했습니다.
그리고 나머지 제목 검증로직은 카테고리에서든, 검색에서든 거의 비슷하게 동작해야하는데 따로 어노테이션을 만드는 것보다는
마크할 그룹 인터페이스를 하나 만들어서 해당 이름을 어노테이션을 통해 검증해서 ToastValidationGroup.class를 가지고 있으면 해당 검증은 피하는식으로
변경했습니다.
개발하면서 어떤 점이 궁금했는지
다른 의견이 있을지..!
🛠️ 테스트
🚀 API Endpoint