Nimble: migrate to Tuist. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Nimble is still evolving and we still advance it, the assumption here was that it's best to keep it as close as possible to the current state implementation of Nimble (as oppose to doing stuff like changing the location of the files, raising deployment target, removing unused stuff and so on). Exception: 1. The swiftlint target is removed, no need to maintain it if we are not using it. 2. The deployment destinations are now only iOS and macOS. If we ever come to need any other, since the code is adapted to it and left unchanged in the migration - we can easily add it. 3. Not really a change, but some of the build settings were extracted to an xcconfig file, to keep things more organized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nimble is still evolving and we still advance it, the assumption here was that it's best to keep it as close as possible to the current state implementation of Nimble (as oppose to doing stuff like changing the location of the files, raising deployment target, removing unused stuff and so on).
Exception: