Fix base requirements #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
reviewed
Feb 5, 2024
| @@ -1,3 +1,2 @@ | |||
| torch>=2.2.0 | |||
| lightning @ git+https://github.com/Lightning-AI/lightning@ed367ca675861cdf40dbad2e4d66f7eee2ec50af | |||
| jsonargparse[signatures] # CLI | |||
There was a problem hiding this comment.
Removing this here means you can now no longer use any of the scripts without installing all.txt. What is the point of making this optional if using lit-gpt needs this anyway for any meaningful use?
There was a problem hiding this comment.
I consider requirements.txt as the requirements for the package and requirements-all.txt as the requirements for the scripts.
The package (model definition, tokenizer, etc) doesn't need jsonargparse because it's not used. It's only used when called as a script
Most CLI users already had to install all requirements for sentencepiece and tokenizers
rasbt
pushed a commit
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment doesnt have requests installed by default anymore (unclear why) which uncovered the bug that we weren't listing it