WIP/Add: NEFTune to Lit-GPT #653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkasmanoff
requested review from
awaelchli,
carmocca and
lantiga
as code owners
|
Hi there, and many thanks for the contribution. I am currently going through some of the older PRs to kind of streamline and organize this repo a bit. I think NEFTune might be somewhat out of scope at the moment, but thanks a lot for spending time on this and working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up an issue I opened last week, feel free to close if no interest or being done elsewhere.
So far I've added it to the LoRA implementation, but could use it as well on the full fine-tuning too.
Lmk!
#642