Automated code fixes with type annotations check. #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrei-Aksionov
requested review from
awaelchli,
carmocca and
lantiga
as code owners
Andrei-Aksionov
commented
Oct 16, 2023
| pandas # prepare_csv.py |
There was a problem hiding this comment.
No new line at the end of the file.
Andrei-Aksionov
commented
Oct 16, 2023
| @@ -25,7 +25,6 @@ | |||
| XLAPrecisionPlugin, | |||
| ) | |||
| from lightning.pytorch.utilities.rank_zero import rank_zero_only as trainer_rank_zero_only | |||
| from pytorch_lightning.plugins import PrecisionPlugin | |||
There was a problem hiding this comment.
Imported but not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
This PR was done with a slightly different
ruffandblackCLI command that includes type hints check and targets minimal supported version of Python - 3.8.For
ruffthese rules are added:ANN001: Missing type annotation for function argument.ANN201: Missing return type annotation for public function.ANN205: Missing return type annotation for staticmethod.ANN206: Missing return type annotation for classmethod.And these rules are skipped for the
testsfolder.