Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify merge_lora hparam sync #631

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Clarify merge_lora hparam sync #631

merged 1 commit into from
Oct 9, 2023

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Oct 9, 2023

Adds a note for users to ensure that the hparam configs in lora.py and merge_lora.py need to match.

@carmocca carmocca merged commit 55006f1 into main Oct 9, 2023
5 checks passed
@carmocca carmocca deleted the improve-lora-merge-docs branch October 9, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasbt @carmocca