Mention that the numbers in markdowns were obtained with CUDA 11.8 #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrei-Aksionov
requested review from
awaelchli,
carmocca and
lantiga
as code owners
awaelchli
approved these changes
Oct 6, 2023
carmocca
reviewed
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
Part of #622
Essentially
tutorials/finetune_lora.mdandtutorials/quantize.mdcontain times required to train and generate respectively, but they were obtained with CUDA v11.8, and the current main installs CUDA v12.1. On the latest version a hardware utilization is better and thus the time to train/generate should be smaller.Before the numbers are updated with the latest version of CUDA I think it's important to mention the version on which they were obtained.