Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize out_dir behavior #1338

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Standardize out_dir behavior #1338

merged 4 commits into from
Apr 23, 2024

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Apr 22, 2024

Apply the init_out_dir(out_dir) used for pretraining also to the finetuning scripts.

Fixes #1312

@awaelchli
Copy link
Contributor

The test_init_out_dir in test_pretrain.py should now be moved to test_utils.py as well.

@rasbt
Copy link
Collaborator Author

rasbt commented Apr 23, 2024

The test_init_out_dir in test_pretrain.py should now be moved to test_utils.py as well.

Good catch, thanks!

@rasbt
Copy link
Collaborator Author

rasbt commented Apr 23, 2024

I think the failing tests are because HF is down again ...

@rasbt rasbt merged commit daad8f9 into main Apr 23, 2024
9 checks passed
@rasbt rasbt deleted the standardize-path-behavior branch April 23, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finetune and Pretrain Path Discrepancy
2 participants
@rasbt @awaelchli