Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vocab size padding in Llama3 config #1334

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix vocab size padding in Llama3 config #1334

merged 2 commits into from
Apr 22, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 22, 2024 •
edited
Loading

The huggingface tokenizer returns the padded vocab size. To be consistent in our config, I'm setting the padded vocab size explicitly.

@awaelchli awaelchli marked this pull request as ready for review April 22, 2024 16:48
carmocca
carmocca approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

My personal HF token is used for the litgpt CI, so since I was just given access to llama 3 now, this started surfacing in CI

@awaelchli
Copy link
Contributor Author

I suspected this. And I missed this because locally I didn't set my token env variable to run tests.

@awaelchli awaelchli merged commit 54628ec into main Apr 22, 2024
9 checks passed
@awaelchli awaelchli deleted the llama3-vocab-size branch April 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awaelchli @carmocca