Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1291

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Update README.md #1291

merged 3 commits into from
Apr 15, 2024

Conversation

williamFalcon
Copy link
Contributor

Clear up what litGPT is/does at the top of readme.

@williamFalcon williamFalcon requested a review from lantiga as a code owner April 15, 2024 15:11
rasbt
rasbt approved these changes Apr 15, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
williamFalcon and others added 2 commits April 15, 2024 12:08
@williamFalcon @rasbt
Update README.md
fbc1852 
Co-authored-by: Sebastian Raschka <[email protected]>
@williamFalcon @rasbt
Update README.md
fdbc847 
Co-authored-by: Sebastian Raschka <[email protected]>
@williamFalcon
Copy link
Contributor Author

williamFalcon commented Apr 15, 2024 •
edited
Loading

@rasbt @Andrei-Aksionov can we get CI back to green please. a PR that changes a readme shouldn't fail... this shows there are real broken tests on the CI.

FYI @lantiga

@williamFalcon
Copy link
Contributor Author

williamFalcon commented Apr 15, 2024 •
edited
Loading

also... why is this taking 24 minutes to install deps?

image

@williamFalcon williamFalcon merged commit d84c5c1 into main Apr 15, 2024
7 of 9 checks passed
@williamFalcon williamFalcon deleted the williamFalcon-patch-1 branch April 15, 2024 16:36
@rasbt
Copy link
Collaborator

rasbt commented Apr 15, 2024

@williamFalcon Totally agree. And I had problems merging PRs because of that in recent days because I don't have the permissions to override the merges if one of the test fails for unrelated reasons. There is a proposed fix by @Andrei-Aksionov in #1292 I believe.

@williamFalcon williamFalcon mentioned this pull request Apr 15, 2024
Closed
@williamFalcon
Copy link
Contributor Author

@williamFalcon Totally agree. And I had problems merging PRs because of that in recent days because I don't have the permissions to override the merges if one of the test fails for unrelated reasons. There is a proposed fix by @Andrei-Aksionov in #1292 I believe.

awesome. let's get it unblocked for sure. i moved the discussion to #1294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrei-Aksionov Andrei-Aksionov Andrei-Aksionov left review comments

@rasbt rasbt rasbt approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamFalcon @rasbt @Andrei-Aksionov