Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitespace after "Instruct:" #1277

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add whitespace after "Instruct:" #1277

merged 1 commit into from
Apr 12, 2024

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Apr 11, 2024

In generate/base.py, the output is

Instruct:Fix typos in the following sentence: Exampel input
Output: Example input.

which looks a bit ugly.

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The QA format from the release doesn't add this space: https://huggingface.co/microsoft/phi-2

I would adhere to the template given

@rasbt
Copy link
Collaborator Author

rasbt commented Apr 12, 2024

It looks like they have it though. Maybe it just got stripped via the line break above.

Screenshot 2024-04-12 at 12 35 43 PM

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phi2 wasn't specifically finetuned for this, right? So it shouldn't be sensitive and I agree with this.

@carmocca carmocca merged commit d6e91ee into main Apr 12, 2024
9 checks passed
@carmocca carmocca deleted the rasbt-patch-3 branch April 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants