Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chat with LoRA #1255

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Fix chat with LoRA #1255

merged 4 commits into from
Apr 8, 2024

Conversation

metame-none
Copy link
Contributor

fix using chat with lora checkpoints.

@metame-none metame-none changed the title [bug] fix chat with lora [BUG] Fix chat with lora Apr 5, 2024
awaelchli
awaelchli approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a last-minute rename blunder on my part, sorry!
I'll add a test to cover this

@awaelchli awaelchli self-assigned this Apr 5, 2024
@awaelchli awaelchli changed the title [BUG] Fix chat with lora Fix chat with LoRA Apr 8, 2024
@awaelchli awaelchli merged commit 78bd4ca into Lightning-AI:main Apr 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees

@awaelchli awaelchli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metame-none @awaelchli