Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoneType error when reading custom data from a JSON file #1241

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 3, 2024

Fixes an issue when you forget to set the val_split_fraction. It is optional normally in case the path is a directory with splits. But when the path is a file, it must be set because LitGPT does not support training without validation.

@carmocca carmocca merged commit c32eddb into main Apr 3, 2024
8 checks passed
@carmocca carmocca deleted the bugfix/json-none-error branch April 3, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants