Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention usage of related finetunes #1223

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Mention usage of related finetunes #1223

merged 1 commit into from
Apr 1, 2024

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Apr 1, 2024

I added an additional info box under the model list in hope that it makes this info more prominent. I think it might not hurt as it is sometimes overlooked by users.

@Andrei-Aksionov
Copy link
Collaborator

I think it's a better placement.
But what about this: https://github.com/Lightning-AI/litgpt/blob/main/tutorials/download_model_weights.md#finetunes-and-other-model-variants
You want to keep it?

@rasbt
Copy link
Collaborator Author

rasbt commented Apr 1, 2024

I think it doesn't hurt to keep it because it can be linked directly via the hyperlink ref whereas the box can't unfortunately.

@rasbt rasbt merged commit 1336976 into main Apr 1, 2024
8 checks passed
@rasbt rasbt deleted the rasbt-patch-1 branch April 1, 2024 17:58
@carmocca
Copy link
Contributor

carmocca commented Apr 2, 2024

I find it odd to have the block of text twice in the same file

rasbt added a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants