Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tinystories in pretrain/debug.yaml #1203

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca self-assigned this Mar 27, 2024
@rasbt
Copy link
Collaborator

rasbt commented Mar 27, 2024

Thanks! Are you planning to update the docs too?

@carmocca
Copy link
Contributor Author

I didn't intend to. At least not as #1082 suggest which is a broader revisit of the pretaining tutorial

@rasbt
Copy link
Collaborator

rasbt commented Mar 27, 2024

No problem, just wanted to make sure that this doesn't accidentally close #1082, so we don't forget to address the docs separately. (I am just seeing though that it's Fixes 1082 **(comment)** so maybe the whole issue won't be closed upon merging. Seeing the (comment) the first time and I guess I learned something new ... again 😅

@carmocca carmocca merged commit a7acf99 into main Mar 27, 2024
8 checks passed
@carmocca carmocca deleted the carmocca/tinystories-debug branch March 27, 2024 18:57
@carmocca
Copy link
Contributor Author

carmocca commented Mar 27, 2024

It does close it. Now we know haha

rasbt pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TinyStories to the pretraining docs
2 participants