reset_parameters fixes
#1199
Merged
reset_parameters fixes
#1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -151,7 +151,8 @@ def scaled_dot_product_attention( | |||
| return y + self.gating_factor * ay | |||
|
|
|||
| def reset_parameters(self) -> None: | |||
| torch.nn.init.zeros_(self.gating_factor) | |||
| if hasattr(self, "gating_factor"): | |||
There was a problem hiding this comment.
Good catch.
Adapter is added only at config.adapter_start_layer, so not all layers have it.
| self.lora_A = nn.Parameter(torch.zeros((r, in_features))) | ||
| self.lora_B = nn.Parameter(torch.zeros((out_features, r))) | ||
| self.lora_A = nn.Parameter(torch.empty((r, in_features))) | ||
| self.lora_B = nn.Parameter(torch.empty((out_features, r))) | ||
| self.scaling = self.lora_alpha / self.r | ||
| self.reset_parameters() |
There was a problem hiding this comment.
I feel like reset_parameters should be called automatically by torch during a layer creation. But I highly unconfident about that.
There was a problem hiding this comment.
It's more of a silent convention. Only FSDP calls it
Andrei-Aksionov
approved these changes
Mar 26, 2024
awaelchli
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.