GemmaMLP: add missing approximation for LoRA and AdapterV2 variants #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrei-Aksionov
requested review from
awaelchli,
carmocca and
lantiga
as code owners
|
Thank you! |
rasbt
pushed a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
In #1004 I added GeLU approximation only to the base implementation and totally forgot about LoRA and AdapterV2 variants.
In added tests there is a
pytest.mark.xfailbecause I couldn't fine the reason, at least for now.When I moved all the tests from
tests/test_model.pyinto LoRA and AdapterV2 tests (and replaced base GPT with the corresponding variant) all the tests passed, except for Gemma.Later I'll come back to the test, most likely after #1031.