Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate download docs #1080

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Consolidate download docs #1080

merged 5 commits into from
Mar 12, 2024

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Mar 11, 2024

I replaced the individual download docs by a general download doc. First, I was combining them into one gigantic document, but then I thought it was kind of overkill. What do you think, is there any information from the individual docs that we definitely want to keep?

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the comments are addressed

tutorials/download_model_weights.md Outdated Show resolved Hide resolved
tutorials/download_model_weights.md Outdated Show resolved Hide resolved
tutorials/download_model_weights.md Outdated Show resolved Hide resolved
tutorials/download_model_weights.md Outdated Show resolved Hide resolved
tutorials/download_model_weights.md Show resolved Hide resolved
@rasbt
Copy link
Collaborator Author

rasbt commented Mar 12, 2024

All your suggestions should be addressed now. Good call regarding --tokenizers_only!

@carmocca carmocca merged commit 1e9994e into wip Mar 12, 2024
7 checks passed
@carmocca carmocca deleted the new-downl-docs branch March 12, 2024 02:39
awaelchli pushed a commit that referenced this pull request Mar 15, 2024
awaelchli pushed a commit that referenced this pull request Mar 15, 2024
awaelchli pushed a commit that referenced this pull request Mar 15, 2024
rasbt added a commit that referenced this pull request Mar 18, 2024
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants