Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

removes old Noir dependencies, replaces defpage with compojure route #16

Closed
wants to merge 2 commits into from

Conversation

ddellacosta
Copy link

(Note that this incorporates bvandgrift's pull request: #15)

This is kind of an "exploratory" pull request. I'm using fetch in a project which is ripping out most of the Noir stuff, but I wanted to keep using fetch. So spiked out a quick solution by replacing the defpage call with a simple Compojure route.

Of course this also necessitates adding the route to your app's handlers, which means it would probably make sense to add some middleware for this...like say um, wrap-remote...

So, not sure if this is something you want to do or not, but since Noir is deprecated and many folks seem to be moving to lib-noir (I think?). On the other hand, this would be a pretty big breaking change, so I'm not sure if it makes sense to do this outside of a fork now.

If you want, I'll write some tests for it, flesh out wrap-remote (again) and tweak the instructions in the README. If not, I'll fork it properly, renaming it to "fetch-sans-noir" or something.

Cheers--DD

@ddellacosta ddellacosta closed this Jul 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant