-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate 1.27mm tht headers and sockets #63
base: master
Are you sure you want to change the base?
Conversation
10ace75
to
2622444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some flake8 issues and the pipenv stuff. Other than that I'd need to look at it more deeply and especially verify if it doesn't change all the other headers and sockets.
Whoops! I was pretty sure I'd not committed the pipfile, and I had committed the flake8 changes! Must have sleepily staged the pipfile instead of the python file... Anyway, all fixed. I have verified that it doesn't change all the other headers and sockets - apart from the metadata (tags list). Here's an example diff: |
2622444
to
688671e
Compare
I checked that it doesn't change the other headers apart from metadata. You can see the diff above and check for yourself if you don't trust me! I'm also happy to rebase this and re-test. |
No, if somebody tested it we should be fine 🙂 |
@RX14 sorry for the long delays in reviewing. You don't need to close it, we will take a look sometime 🙂 |
That's fine, but be aware that I'm not so interested in addressing reviews any more though, so any reviews will have to be addressed yourself |
Sure, that's perfectly fine. You don't owe us anything (thanks for the contribution so far), so if it's fine for you we can take over once one of us finds time to review your work! |
The drill sizes i got from various datasheets and seem the right ballpark. The pad sizes are the largest I can fit without getting DRC errors for being too close to the silkscreen...