Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sym/cmp for screw terminals #13

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add sym/cmp for screw terminals #13

merged 1 commit into from
Feb 15, 2024

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Jul 16, 2022

Generated by librepcb-parts-generator (PR 96).

SUMMARY

Add generated symbols and components for screw terminals.

This is a screw terminal:

image

And here's the generated symbol:

screenshot-20220716-232200 screenshot-20220716-232240

DATASHEETS / REFERENCES

None, but I used KiCad for inspiration. See LibrePCB/librepcb-parts-generator#96 for details.

OPEN QUESTIONS / UNRESOLVED ISSUES

None

CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@dbrgn dbrgn added the enhancement Improving an existing library element. label Jul 16, 2022
@dbrgn dbrgn requested a review from ubruhin July 16, 2022 21:27
@dbrgn dbrgn self-assigned this Jul 16, 2022
@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. and removed enhancement Improving an existing library element. labels Aug 25, 2023
Generated by librepcb-parts-generator (PR 96).
@dbrgn
Copy link
Contributor Author

dbrgn commented Feb 15, 2024

@ubruhin PR updated!

The new symbol looks like this in LibrePCB though, the circles are hidden below the yellow rectangle:

screenshot-20240215-203828

I think that's a rendering bug that was already fixed in the current master branch, right? How should we proceed?

@ubruhin
Copy link
Contributor

ubruhin commented Feb 15, 2024

Thanks for updating!

I think that's a rendering bug that was already fixed in the current master branch, right? How should we proceed?

True, this will be fixed with the next release. And I just verified that the screw terminals look correct in the schematic editor of LibrePCB 1.0.0 - seems that only the symbol editor (and the "Add component"-dialog) is affected by the bug so I'd say it's fine to merge this PR without waiting for the fix.

@dbrgn dbrgn merged commit 2c662cc into master Feb 15, 2024
2 checks passed
@dbrgn dbrgn deleted the screw-terminals branch February 15, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

2 participants