Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement INFO command #128

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Implement INFO command #128

merged 3 commits into from
Jul 2, 2024

Conversation

internet-catte
Copy link
Contributor

@internet-catte internet-catte commented May 22, 2024

>>> INFO
:server1.test 371 a :Sable --
:server1.test 371 a :
:server1.test 371 a :Copyright (c) 2021-2024 Sable Development Team
:server1.test 371 a :
:server1.test 371 a :This program is free software: you can redistribute it and/or modify
:server1.test 371 a :it under the terms of the GNU Affero General Public License as published
:server1.test 371 a :by the Free Software Foundation, either version 3 of the License, or
:server1.test 371 a :(at your option) any later version.
:server1.test 371 a :
:server1.test 371 a :Source code is available at: https://github.com/Libera-Chat/sable
:server1.test 371 a :
:server1.test 371 a :A list of contributors can be found in the git log.
:server1.test 371 a :
:server1.test 371 a :Visit the Sable website at: https://sable.chat/
:server1.test 371 a :Visit us on IRC at irc.libera.chat #libera-dev
:server1.test 371 a :
:server1.test 371 a :Version: sable-0.1.0-aabc527319a4e9ff2dfb8d1e45ee35e3bbf0116f-dirty
:server1.test 371 a :Commit date: Thu, 23 May 2024 13:48:00 +0000
:server1.test 374 a :End of /INFO list

AUTHORS Outdated Show resolved Hide resolved
sable_ircd/info.txt Outdated Show resolved Hide resolved
@internet-catte internet-catte force-pushed the catte/info branch 2 times, most recently from 83d3aac to aabc527 Compare May 23, 2024 17:48
@spb
Copy link
Collaborator

spb commented May 24, 2024

:server1.test 371 a :Build date: Wed, 22 May 2024 22:12:16 +0000

I don't think build date is actually what we want here - the commit date would be far more useful.

@internet-catte
Copy link
Contributor Author

should the build time be used if the tree is dirty?

@spb
Copy link
Collaborator

spb commented May 24, 2024

No, unless you can think of a way it would be meaningfully useful. Commit date is useful because if you're trying to quickly identify which servers do or don't have a given fix applied, you can filter on commit date without needing the git log to know which commit IDs contain the one you're after. Build date doesn't tell you that and can be actively misleading if you're unlucky.

currently returns:
- copyright info
- author info
- website and irc channel
- version
- commit datetime
@spb spb merged commit a16f32b into Libera-Chat:master Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants