-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group results by articles rather than show individual paragraphs #15
Conversation
Since there are some very long paragraphs (depending on the search query), it would be nice to have an easier way to get to the article than scrolling all the way down to the bottom of the list of articles. Keeping your original approach of linking the text (in addition to the button at the bottom if you want) might be a nice touch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are some very long paragraphs (depending on the search query), it would be nice to have an easier way to get to the article than scrolling all the way down to the bottom of the list of articles. Keeping your original approach of linking the text (in addition to the button at the bottom if you want) might be a nice touch
+1 some paragraphs returned are pretty long. Can we set a max num characters on the portion of the paragraph that is displayed?
} | ||
.app .results-container .single-result-container .article-actions button { | ||
margin: 1rem; | ||
min-width: 100px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: change to rem
Oh ok, will add as an issue |
I cannot link the demo though as that would require deploying to Heroku and would break the current build, I can work on having a stage env later on though. This is issue #14