Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group results by articles rather than show individual paragraphs #15

Merged
merged 4 commits into from
Jul 27, 2020

Conversation

Lev-Stambler
Copy link
Owner

  • Return results by highest scoring articles
  • Under each article, show the 2 highest scoring paragraphs with the option of expanding to see more or going to the site itself

I cannot link the demo though as that would require deploying to Heroku and would break the current build, I can work on having a stage env later on though. This is issue #14

@Lev-Stambler
Copy link
Owner Author

Screenshot_2020-07-23_063012
Screenshot_2020-07-23_063005

@Lev-Stambler Lev-Stambler marked this pull request as ready for review July 23, 2020 12:04
@cwlarson-google cwlarson-google linked an issue Jul 23, 2020 that may be closed by this pull request
@cwlarson-google
Copy link
Collaborator

Since there are some very long paragraphs (depending on the search query), it would be nice to have an easier way to get to the article than scrolling all the way down to the bottom of the list of articles. Keeping your original approach of linking the text (in addition to the button at the bottom if you want) might be a nice touch

Copy link
Collaborator

@vitashubin vitashubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are some very long paragraphs (depending on the search query), it would be nice to have an easier way to get to the article than scrolling all the way down to the bottom of the list of articles. Keeping your original approach of linking the text (in addition to the button at the bottom if you want) might be a nice touch

+1 some paragraphs returned are pretty long. Can we set a max num characters on the portion of the paragraph that is displayed?

}
.app .results-container .single-result-container .article-actions button {
margin: 1rem;
min-width: 100px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change to rem

@Lev-Stambler
Copy link
Owner Author

Since there are some very long paragraphs (depending on the search query), it would be nice to have an easier way to get to the article than scrolling all the way down to the bottom of the list of articles. Keeping your original approach of linking the text (in addition to the button at the bottom if you want) might be a nice touch

Oh ok, will add as an issue

@Lev-Stambler Lev-Stambler merged commit 437a539 into master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants