Skip to content

Commit

Permalink
Remove constraints on package versions in conflicts, it's unsupported
Browse files Browse the repository at this point in the history
After a debugging session with @kit-ty-kate as part of fixing
tarides/opam-monorepo#349 and
ocaml-opam/opam-0install-solver#46 we realized
that OPAM doesn't support resolving package variables in `conflicts`
fields (the linter complains about this in `depends` fileds but not in
`conflicts` fields, but the solver never resolves these variables). So
this constraint doesn't do anything in OPAM and it causes issues in the
opam-0install-solver which attempts to resolve them.
  • Loading branch information
Leonidas-from-XIV committed Apr 28, 2023
1 parent 24ff26d commit e3506c9
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions packages/ocaml-options-vanilla/ocaml-options-vanilla.1/opam
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,7 @@ depends: [
conflicts: [
"ocaml-option-32bit"
"ocaml-option-afl"
"ocaml-option-bytecode-only"
{ocaml-system:version < "5" |
ocaml-base-compiler:version < "5" |
ocaml-variants:version < "5" |
arch = "arm64" |
arch = "x86_64" }
"ocaml-option-bytecode-only" {arch = "arm64" | arch = "x86_64" }
"ocaml-option-default-unsafe-string"
"ocaml-option-flambda"
"ocaml-option-fp"
Expand Down

0 comments on commit e3506c9

Please sign in to comment.