Skip to content

Commit

Permalink
PR remarks fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
tdejoigny-ledger committed Jul 29, 2024
1 parent ee2ddef commit 356987e
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 8 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/continuous-integration-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,16 @@ jobs:
test_dir: tests
speculos_app_branch_name: ${{ github.ref }}

package_and_test_docker_for_nanos:
name: Build and test the Speculos docker for Nano S
uses: ./.github/workflows/reusable_ragger_tests_latest_speculos.yml
needs: [package_and_test_docker]
with:
app_repository: LedgerHQ/app-boilerplate
app_branch_name: nanos_baseline
test_dir: tests
speculos_app_branch_name: ${{ github.ref }}

deploy_docker:
name: Build and Upload the Speculos docker
runs-on: ubuntu-latest
Expand Down
19 changes: 11 additions & 8 deletions .github/workflows/reusable_ragger_tests_latest_speculos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,22 @@ jobs:
name: speculos_image
path: /tmp/speculos_image.tar

call_get_app_metadata:
name: Retrieve application metadata
uses: LedgerHQ/ledger-app-workflows/.github/workflows/_get_app_metadata.yml@v1
with:
app_repository: ${{ inputs.app_repository }}
app_branch_name: ${{ inputs.app_branch_name }}

ragger_tests:
name: Functional tests with Ragger
runs-on: ubuntu-latest
needs: [build_docker_image, build_application]
needs: [build_docker_image, build_application, call_get_app_metadata]
strategy:
fail-fast: false
matrix:
include:
- device: nanos
- device: nanox
- device: nanosp
- device: stax
- device: flex
device: ${{ fromJSON(needs.call_get_app_metadata.outputs.compatible_devices) }}

steps:
- name: Clone
uses: actions/checkout@v4
Expand All @@ -83,7 +86,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: ${{ inputs.app_repository }}
ref: ${{ matrix.device == 'nanos' && 'nanos_baseline' || inputs.app_branch_name }}
ref: ${{ inputs.app_branch_name }}
path: app
submodules: recursive
fetch-depth: 0
Expand Down

0 comments on commit 356987e

Please sign in to comment.