Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick fixes for pinpad nanos #833

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

jarevalo-ledger
Copy link
Contributor

@jarevalo-ledger jarevalo-ledger commented Dec 10, 2024

Description

Fix pin keypad behavior to pre-nbgl.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Stay on backspace key until there is a PIN entry to delete

(cherry picked from commit 3ddcf74)
Only shuffle digits, backspace and validate keys must not be selected

(cherry picked from commit 823c5ca)
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (API_LEVEL_22@525c53e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             API_LEVEL_22     #833   +/-   ##
===============================================
  Coverage                ?   35.76%           
===============================================
  Files                   ?       13           
  Lines                   ?     1591           
  Branches                ?        0           
===============================================
  Hits                    ?      569           
  Misses                  ?     1022           
  Partials                ?        0           
Flag Coverage Δ
unittests 35.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jarevalo-ledger jarevalo-ledger merged commit 0f3417c into API_LEVEL_22 Dec 10, 2024
186 checks passed
@jarevalo-ledger jarevalo-ledger deleted the cherry-pick-pinpas-nano branch December 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants