Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove aptos unit test for function assertions #8839

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

fix: remove aptos unit test for function assertions #8839

wants to merge 14 commits into from
+8 −11

Conversation

semeano
Copy link
Contributor

@semeano semeano commented Jan 7, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Remove toBe("function") assertions.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@semeano semeano requested a review from a team as a code owner January 7, 2025 18:35
@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 5:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 5:40pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 5:40pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 5:40pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label Jan 7, 2025
may01
may01 previously approved these changes Jan 7, 2025
View reviewed changes
jccguimaraes
jccguimaraes requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jccguimaraes jccguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

libs/ledger-live-common/src/families/aptos/api/index.test.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the API we need to make sure we expose the correct methods as described here https://github.com/LedgerHQ/ledger-live/blob/develop/libs/coin-framework/src/api/types.ts#L31-L46

libs/ledger-live-common/src/families/aptos/bridge/js.test.ts Show resolved Hide resolved
@semeano semeano requested a review from jccguimaraes January 8, 2025 09:58
@semeano semeano requested a review from may01 January 8, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jccguimaraes jccguimaraes jccguimaraes approved these changes

@may01 may01 Awaiting requested review from may01

Assignees

@semeano semeano

Labels
common Has changes in live-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@semeano @may01 @jccguimaraes