[QAA-307][Detox][Speculos] Adap nft gallery tests #8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
abdurrahman-ledger
force-pushed
the
support/qaa_307_detox_speculos_nftGallery
branch
from
a019a2b to
6c2cdb4
Compare
abdurrahman-ledger
force-pushed
the
support/qaa_307_detox_speculos_nftGallery
branch
from
130a731 to
7659732
Compare
Base automatically changed from
support/qaa_377_detox_speculos_send
to
develop
January 8, 2025 16:16
abdurrahman-ledger
force-pushed
the
support/qaa_307_detox_speculos_nftGallery
branch
2 times, most recently
from
a2cd4aa to
22c7e4d
Compare
abdurrahman-ledger
force-pushed
the
support/qaa_307_detox_speculos_nftGallery
branch
from
22c7e4d to
5718b63
Compare
| @@ -17,12 +24,15 @@ export default class NftGalleryPage { | |||
| nftFilterDrawer = () => getElementById("wallet-nft-gallery-filter-drawer"); | |||
| selectAndHide = () => getElementById("wallet-nft-gallery-select-and-hide"); | |||
| confirmHide = () => getElementById("wallet-nft-gallery-confirm-hide"); | |||
| nftListItem = (index: number) => getElementById(`wallet-nft-gallery-list-item-${index}`); | |||
| nftListItemId = (index = 0) => `wallet-nft-gallery-list-item-${index}`; | |||
There was a problem hiding this comment.
Since index 0, shouldn't the name reflect it as "firstNftListItemId"? Same for the next line
| @@ -35,39 +45,71 @@ export default class NftGalleryPage { | |||
| await expect(this.nftListItem(index)).not.toBeVisible(); | |||
| } | |||
|
|
|||
| @Step("Hide All Nft") | |||
| async hideAllNft() { | |||
| const nftNumber = Number.parseInt( | |||
There was a problem hiding this comment.
Can you please add a comment explaining what is happening with this method? since it doesn't look straightforward
| @@ -75,6 +75,7 @@ describe(`Ledger Sync Accounts`, () => { | |||
| } | |||
|
|
|||
| $TmsLink(tmsLink); | |||
| $Issue("LIVE-15614"); | |||
There was a problem hiding this comment.
will it be visible in the Allure report as a bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached. (no need)📝 Description
❓ Context
🧐 Checklist for the PR Reviewers