feat 📈 (llm): add analytics for new accounts list #8818
+75
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
LucasWerey
changed the title
LucasWerey
force-pushed
the
feat/LIVE-15618
branch
from
3eec45d to
1cf50ae
Compare
themooneer
reviewed
Jan 7, 2025
| @@ -103,10 +103,11 @@ export default function AccountsList({ route }: Props) { | |||
| }, [currency, llmNetworkBasedAddAccountFlow?.enabled, navigation, provider, specificAccounts]); | |||
|
|
|||
| const onClick = specificAccounts ? onAddAccount : undefined; | |||
|
|
|||
| const pageTrackingEvent = specificAccounts ? "Account List Summary" : "Accounts"; | |||
| const currencyToTrack = specificAccounts && currency?.name; | |||
There was a problem hiding this comment.
replace this expression with a ternary to avoid sending boolean to analytics
themooneer
reviewed
Jan 7, 2025
| @@ -103,10 +103,11 @@ export default function AccountsList({ route }: Props) { | |||
| }, [currency, llmNetworkBasedAddAccountFlow?.enabled, navigation, provider, specificAccounts]); | |||
|
|
|||
| const onClick = specificAccounts ? onAddAccount : undefined; | |||
|
|
|||
| const pageTrackingEvent = specificAccounts ? "Account List Summary" : "Accounts"; | |||
There was a problem hiding this comment.
i suggestion to extract those strings to enums related to features/Accounts analytics. File naming can be enums.ts , location IMO features/Accounts/enums.ts as it can be used anywhere in the feature
LucasWerey
force-pushed
the
feat/LIVE-15618
branch
3 times, most recently
from
438ba0d to
fd60fe2
Compare
LucasWerey
force-pushed
the
feat/LIVE-15618
branch
from
fd60fe2 to
5d6c6a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add analytics for the new accounts list scope.
Please refer to Jira task to review all the needed analytics
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-07.at.10.51.26.mp4
❓ Context
🧐 Checklist for the PR Reviewers