Support/chang hardfork bis #8812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
qperrot
reviewed
Jan 6, 2025
|
|
||
| // const stakeCredential = getAccountStakeCredential(account.xpub as string, account.index); | ||
| // const stakeKeyHashCredential: TyphonTypes.HashCredential = { | ||
| // hash: Buffer.from(stakeCredential.key, "hex"), |
There was a problem hiding this comment.
Don't you want to delete all those comments ?
There was a problem hiding this comment.
Hi @qperrot, this changes are temporary and that commented code will be in use later 🙂
qperrot
approved these changes
Jan 6, 2025
3 tasks
ThatOneCalculator
pushed a commit
to ThatOneCalculator/ledger-live
that referenced
this pull request
Jan 6, 2025
* disable rewards withdraw * add changeset --------- Co-authored-by: pavanvora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Original PR: #8770
With the upcoming Cardano hard fork every Cardano wallet will be required to participate in governance by selecting a DRep and without doing so they won't be able to withdraw the rewards.
The current implementation has auto withdrawal of the rewards, which will break after the hard fork. This is a work around PR so users can continue using their wallet as normal with their rewards being locked until the DRep feature gets implemented to Ledger Live.
❓ Context
🧐 Checklist for the PR Reviewers