Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scan & device accounts - add account v2 #8802

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

themooneer
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

PLEASE DO NOT REVIEW THIS PR TILL IT WILL BE STABLE AND READY

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 4:27pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 4:27pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 4:27pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 4:27pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jan 3, 2025
@themooneer themooneer force-pushed the feat/LIVE-15524 branch 2 times, most recently from 1bd5924 to 7788db9 Compare January 3, 2025 17:14
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 3, 2025

Mobile Bundle Checks

Comparing 94a1ec5 against 11be2e9.

⚠️ main.ios.jsbundle bundle size significantly increased: 61.7mb -> 62.3mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 61.7mb -> 62.3mb. Please check if this is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant