Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: monochrome launcher icon for Android #8795

Conversation

ThatOneCalculator
Copy link
Contributor

@ThatOneCalculator ThatOneCalculator commented Jan 3, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Android app icon

πŸ“ Description

Adds a monochrome/themed version of the Android icon for Android 12+

Before After

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ThatOneCalculator ThatOneCalculator requested a review from a team as a code owner January 3, 2025 02:21
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 5:40pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 5:40pm
web-tools ⬜️ Ignored (Inspect) Jan 6, 2025 5:40pm

Copy link

vercel bot commented Jan 3, 2025

@ThatOneCalculator is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added mobile Has changes in LLM fork Pull request base branch comes from a fork. labels Jan 3, 2025
Copy link
Contributor

@LucasWerey LucasWerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thanks for your contribution !
LGTM

@LucasWerey
Copy link
Contributor

LucasWerey commented Jan 6, 2025

Hello @ThatOneCalculator could you please sign your commits πŸ™
We won't be able to merge it without
You can refer to this if needed : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@ThatOneCalculator ThatOneCalculator requested review from a team as code owners January 6, 2025 17:39
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched cli labels Jan 6, 2025
@ThatOneCalculator
Copy link
Contributor Author

@LucasWerey sorry about that -- my commits are usually signed with my PGP key, but I did the fixup commits on a different machine which wasn't configured for signing yet.

Kinda messed up this branch when attempting to retroactively sign my commits, will remake this PR. Apologies :(

@ThatOneCalculator
Copy link
Contributor Author

Re-up'd on #8825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants