Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aptos): synchronisation unit tests #8794

Open
wants to merge 12 commits into
base: feat/integrate-aptos
Choose a base branch
from

Conversation

semeano
Copy link

@semeano semeano commented Jan 2, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Synchronisation unit tests.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 3, 2025 6:19pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 6:19pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 6:19pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 6:19pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label Jan 2, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 2, 2025

Desktop Bundle Checks

Comparing 1c31d7f against a070f4e.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 1c31d7f against a070f4e.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

@semeano semeano marked this pull request as ready for review January 3, 2025 18:15
@semeano semeano requested a review from a team as a code owner January 3, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant