Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 LLD - Fix Send StepConfirmation error message layout that was broken on some languages #8790

Merged
merged 1 commit into from
Jan 3, 2025
Merged

💄 LLD - Fix Send StepConfirmation error message layout that was broken on some languages #8790

merged 1 commit into from
Jan 3, 2025

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Jan 2, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix Send StepConfirmation error message layout that was broken on some languages

Figma : https://www.figma.com/design/CJSTinoHMRsHDYeS1ylm6E/LLD%2FLLM-Error-Messages?node-id=1747-12251&m=dev

📸 Demo : https://github.com/user-attachments/assets/08989b8a-1c39-480e-83ca-1adc33ebe695

Screenshot 2025-01-02 at 17 25 20

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner January 2, 2025 16:32
@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 10:30am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 10:30am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 10:30am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 10:30am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 2, 2025
@cgrellard-ledger cgrellard-ledger force-pushed the bugfix/lld-send-error-message-layout branch from 18ce075 to ac4a653 Compare January 3, 2025 09:09
@cgrellard-ledger cgrellard-ledger force-pushed the bugfix/lld-send-error-message-layout branch from ac4a653 to 386a51b Compare January 3, 2025 10:30
themooneer
themooneer approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code)
Attempt to test the scenario to see the UI, unfortunately i didn't reach this very specific exception.

@cgrellard-ledger cgrellard-ledger merged commit c6783d2 into develop Jan 3, 2025
40 of 41 checks passed
@cgrellard-ledger cgrellard-ledger deleted the bugfix/lld-send-error-message-layout branch January 3, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@cgrellard-ledger cgrellard-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrellard-ledger @themooneer