Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aptos): index api #8778

Merged
merged 13 commits into from
Jan 3, 2025
Merged

test(aptos): index api #8778

merged 13 commits into from
Jan 3, 2025

Conversation

semeano
Copy link

@semeano semeano commented Dec 31, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Unit tests for index api for Aptos coin.

Coverage:
100% Statements 64/64
100% Branches 12/12
100% Functions 17/17
100% Lines 64/64

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 2, 2025 8:49pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:49pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Dec 31, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 31, 2024

Desktop Bundle Checks

Comparing c3b35dd against 8d2cf10.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing c3b35dd against 8d2cf10.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

@semeano semeano marked this pull request as ready for review January 2, 2025 13:00
@semeano semeano requested review from a team as code owners January 2, 2025 13:00
@semeano semeano changed the base branch from develop to feat/integrate-aptos January 2, 2025 13:02
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs labels Jan 2, 2025
@live-github-bot live-github-bot bot removed tools Has changes in tools translations Translation files have been touched cli labels Jan 2, 2025
@hedi-edelbloute
Copy link
Member

lgtm, build is red though

@semeano semeano merged commit 89aea3a into feat/integrate-aptos Jan 3, 2025
52 of 56 checks passed
@semeano semeano deleted the test/aptos_index-api branch January 3, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants